Skip to content

Aerospike agent and dashboards #19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 235 commits into
base: master
Choose a base branch
from
Open

Aerospike agent and dashboards #19188

wants to merge 235 commits into from
+52,206 −799

Conversation

mphanias
Copy link

@mphanias mphanias commented Dec 4, 2024

What does this PR do?

Modified the aerospike integration to include all the metrics exposed by aerospike-pormetheus-exporter and multiple dashboard consuming the exported metrics.

Motivation

Expanding Metric Collection and Dashboards, we want to ensure all Aerospike metrics are available in datadog, so customers can have better visibility and provide actionable insights for key metrics, including performance, latency, and resource utilization.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

mphanias and others added 3 commits November 26, 2024 10:57
@mphanias
agent checks and new dashboards
6d9ff20 
modified check and metrics python scripts -
-- to include all aerospike metrics most as gauge
-- latency metrics are added as histograms

added new dashboard covering key aerospike metrics required to be monitored
includes,
- cluster, node, namespace, sindex, sets, users, xdr, basic system-info and latencies
@mphanias
reverted aerospike_cluster label to cluster_name
e0b2898
@sravani-64
Replaced aerospike_cluster label with cluster_name label
6e5f48f
@mphanias mphanias requested review from a team as code owners December 4, 2024 16:39
@mphanias
aerospike-agent-and-dashboards
5173717 
updated Aerospike pulgin version in about script
@mphanias
aerospike-agent-and-dashboards
3df2e42 
reverted the aerospike version to 4.0.0
@mphanias
aerospike-agent-and-dashboards
abaa3fa 
reverted CHANGELOG.md to earlier and actual version
generated changelog using ddev package from pypi with command "ddev release changelog new"
@mphanias
aerospike-agent-and-dashboard
81dc631 
corrected the changelog files location
@mphanias
aerospike-agent-and-dashboard
e9c476c 
updated the correct PR number
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@mphanias
aerospike-agent-and-dashboard
b352d12 
incorporated lint feedback and removed unnessary spaces
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@mphanias
aerospike-agent-and-dashboard
b298492 
removed unneceddary spaces at the end of the line as suggested in lint check
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@mphanias
aerospike-agent-and-dashboard
33d85a9 
removed unnecessary blank lines reported by lint at the end of file
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (617cdb8) to head (c75c1b4).

Additional details and impacted files
Flag Coverage Δ
activemq ?
aerospike 88.39% <86.36%> (-0.45%) ⬇️
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphanias
aerospike-agent-and-dashboard
058f0d4 
renamed label cluster_name as aerospike_cluster as it is forbidden as per github checks,
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@mphanias
aerospike-agent-and-dashboards
26a128c 
added mapping for cluster_name to aerospike_cluster - updated check.py
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

mphanias and others added 16 commits May 21, 2025 15:33
@mphanias
aerospike-agent-and-dashboard
2f7e1e7
@mphanias
aerospike-agent-and-dashboards
7b14170
@mphanias
aerospike-agent-and-dashboards
11326f2
@mphanias
aerospike-agent-and-dashboards
73721cb
@mphanias
aerospike-agent-and-dashboards
d4da069
@mphanias
aerospike-agent-and-dashboard
21cc09d
@mphanias
aerospike-agent-and-dashboards
b599389
@mphanias
Merge branch 'master' into aerospike-agent-and-dashboards
fcdd1bf
@mphanias
Merge branch 'master' into aerospike-agent-and-dashboards
60a1b72
@mphanias
aerospike-agent-and-dashboards
a06d1dd
@mphanias
Merge branch 'master' into aerospike-agent-and-dashboards
56cabfb
@mphanias
Merge branch 'master' into aerospike-agent-and-dashboards
fa2ca7e
@mphanias
aerospike-agent-and-dashboards
6a8871d
@mphanias
Merge branch 'aerospike-agent-and-dashboards' of github.com:mphanias/…
27cd274 
…aerospike-datadog-integrations-core into aerospike-agent-and-dashboards
@mphanias
aerospike-agent-and-dashboards
856608c
@mphanias
Merge branch 'master' into aerospike-agent-and-dashboards
49b6f16
@mphanias mphanias requested a review from iliakur May 22, 2025 16:30
@mphanias
Copy link
Author

@iliakur , I made the suggested changes, request your help in review and any further feedback.

Regards
Phani.

@iliakur
Copy link
Contributor

iliakur commented May 27, 2025

@iliakur , I made the suggested changes, request your help in review and any further feedback.

Regards Phani.

Will get to this next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcretzman michaelcretzman michaelcretzman approved these changes

@iliakur iliakur Awaiting requested review from iliakur

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
agent/requested-changes Do Not Merge docs/approved documentation ecosystems/review-requested integration/aerospike product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mphanias @iliakur @michaelcretzman @sravani-64